From 6fc3620be4a4ec0daa978d17e8b88479318d1306 Mon Sep 17 00:00:00 2001
From: Kevin J Hoerr <kjhoerr@protonmail.com>
Date: Sat, 21 Dec 2019 13:01:36 -0500
Subject: AOC-3 Catch promise rejections in POST request

---
 CHANGELOG.md  | 5 +++++
 src/index.ts  | 2 +-
 src/routes.ts | 9 ++++++---
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9df259e..7cd8669 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Catch promise rejections for POST endpoint
+- Default error descriptions for logged errors
+
 ## [0.3.2]
 
 ### Changed
diff --git a/src/index.ts b/src/index.ts
index 27f4572..7d018fe 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -57,7 +57,7 @@ processTemplate(bashTemplate)
 new MongoClient(MONGO_URI, { useUnifiedTopology: true }).connect(
   (err, mongo) => {
     if (err !== null) {
-      logger.error(err);
+      logger.error(err ?? "Unable to connect to database");
       process.exit(1);
     }
 
diff --git a/src/routes.ts b/src/routes.ts
index 79b6fea..c3b2832 100644
--- a/src/routes.ts
+++ b/src/routes.ts
@@ -101,7 +101,10 @@ export default (metadata: Metadata): Router => {
           result
             ? res.status(200).send()
             : res.status(500).send(Messages.UnknownError)
-        );
+        ).catch(err => {
+          logger.error(err ?? "Unknown error occurred while processing POST request");
+          return res.status(500).send(Messages.UnknownError)
+        });
     });
   });
 
@@ -138,7 +141,7 @@ export default (metadata: Metadata): Router => {
         }
       },
       err => {
-        logger.error(err);
+        logger.error(err ?? "Error occurred while fetching commit for GET request");
         res.status(500).send(Messages.UnknownError);
       }
     );
@@ -162,7 +165,7 @@ export default (metadata: Metadata): Router => {
         }
       },
       err => {
-        logger.error(err);
+        logger.error(err ?? "Error occurred while fetching commit for GET request");
         res.status(500).send(Messages.UnknownError);
       }
     );
-- 
cgit