From 3205965afbd9c4fce00dc03cccd6b6223ddb1d15 Mon Sep 17 00:00:00 2001 From: Kevin J Hoerr Date: Sun, 8 Dec 2019 14:17:23 -0500 Subject: Overhaul error handling for controllers This change fixes various issues with the GET endpoints to return more accurate error messages. It adds business logic error objects that are returned in a union type in the controllers. This change should help separate the business logic from the actual errors from upstream services. There may be required changes still with handling those upstream errors via Promises. Integration tests should be added to verify issues. --- src/errors.ts | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 src/errors.ts (limited to 'src/errors.ts') diff --git a/src/errors.ts b/src/errors.ts new file mode 100644 index 0000000..4026164 --- /dev/null +++ b/src/errors.ts @@ -0,0 +1,13 @@ +export class BranchNotFoundError extends Error { + constructor() { + super(); + this.message = "Branch not found"; + } +} + +export class InvalidReportDocumentError extends Error { + constructor() { + super(); + this.message = "Invalid report document"; + } +} -- cgit