From ddecabba54eb24ab4ac07a67621f805d3ad9e2ce Mon Sep 17 00:00:00 2001 From: Kevin J Hoerr Date: Sun, 26 Apr 2020 21:53:26 -0400 Subject: These changes moved a lot of the startup async to run in a streamlined async init function. This brings more logic "to light", so it should probably have unit tests added to check the edge cases. As a bonus, no async runs as a result of route initialization. Speaking of routes, it might be nice to trim down the route calls themselves with async functions, if possible. The upload routes in particular use a lot of async. Just a note for the future. --- src/util/config.test.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/util/config.test.ts') diff --git a/src/util/config.test.ts b/src/util/config.test.ts index 19d7564..418edb7 100644 --- a/src/util/config.test.ts +++ b/src/util/config.test.ts @@ -1,11 +1,11 @@ +const exit = jest + .spyOn(process, "exit") + .mockImplementation(() => undefined as never); + import { configOrError, handleShutdown } from "./config"; import { MongoClient } from "mongodb"; import { Server } from "http"; -const exit = jest.spyOn(process, "exit").mockImplementation(() => { - throw Error(""); -}); - const CommonMocks = { connect: jest.fn(), isConnected: jest.fn(), @@ -111,7 +111,7 @@ describe("handleShutdown", () => { } // Assert - expect(exit).toHaveBeenCalledWith(1); + expect(exit).toHaveBeenCalledWith(0); }); it("should exit with error with Mongo error", async () => { -- cgit