aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKevin J Hoerr <kjhoerr@protonmail.com>2019-12-21 13:01:36 -0500
committerKevin J Hoerr <kjhoerr@protonmail.com>2019-12-21 13:01:36 -0500
commit6fc3620be4a4ec0daa978d17e8b88479318d1306 (patch)
treed68c41167d13c25ce13d5c369984fb3d6b40ca8d
parentc6fa73e1a3d5a69f5770e0a200824ffdb253f868 (diff)
downloadao-coverage-6fc3620be4a4ec0daa978d17e8b88479318d1306.tar.gz
ao-coverage-6fc3620be4a4ec0daa978d17e8b88479318d1306.tar.bz2
ao-coverage-6fc3620be4a4ec0daa978d17e8b88479318d1306.zip
AOC-3 Catch promise rejections in POST request
-rw-r--r--CHANGELOG.md5
-rw-r--r--src/index.ts2
-rw-r--r--src/routes.ts9
3 files changed, 12 insertions, 4 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9df259e..7cd8669 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
+### Changed
+
+- Catch promise rejections for POST endpoint
+- Default error descriptions for logged errors
+
## [0.3.2]
### Changed
diff --git a/src/index.ts b/src/index.ts
index 27f4572..7d018fe 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -57,7 +57,7 @@ processTemplate(bashTemplate)
new MongoClient(MONGO_URI, { useUnifiedTopology: true }).connect(
(err, mongo) => {
if (err !== null) {
- logger.error(err);
+ logger.error(err ?? "Unable to connect to database");
process.exit(1);
}
diff --git a/src/routes.ts b/src/routes.ts
index 79b6fea..c3b2832 100644
--- a/src/routes.ts
+++ b/src/routes.ts
@@ -101,7 +101,10 @@ export default (metadata: Metadata): Router => {
result
? res.status(200).send()
: res.status(500).send(Messages.UnknownError)
- );
+ ).catch(err => {
+ logger.error(err ?? "Unknown error occurred while processing POST request");
+ return res.status(500).send(Messages.UnknownError)
+ });
});
});
@@ -138,7 +141,7 @@ export default (metadata: Metadata): Router => {
}
},
err => {
- logger.error(err);
+ logger.error(err ?? "Error occurred while fetching commit for GET request");
res.status(500).send(Messages.UnknownError);
}
);
@@ -162,7 +165,7 @@ export default (metadata: Metadata): Router => {
}
},
err => {
- logger.error(err);
+ logger.error(err ?? "Error occurred while fetching commit for GET request");
res.status(500).send(Messages.UnknownError);
}
);